Mirth Connect

Web Service Sender: WSDL URL Get Operations fails with non-standard port and authentication

Details

Description

Enter a URL in the WDSL URL field in a Web Service Sender, and if you are using a non-standard port (80 for http, 443 for https) as well as username/password authentication, you'll get the "Error caching WSDL" error message.

The port section of the URL is discarded in the code that inserts the authentication details into the URL. I imagine a non-standard port works fine if auth is disabled, but haven't tested that case.

The actual error is in WebServiceConnectorService.getWsdlInterface() – I'll attach a patch.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rob Whelan added a comment -

Patch for the server project. Technically made against the 2.2.1 tag, but this file hasn't changed on trunk since then.

Show
Rob Whelan added a comment - Patch for the server project. Technically made against the 2.2.1 tag, but this file hasn't changed on trunk since then.
Hide
Permalink
Rob Whelan added a comment -

Description should read "... non-standard port (vs. 80 for http, 443 for https) ..."

Show
Rob Whelan added a comment - Description should read "... non-standard port ( vs. 80 for http, 443 for https) ..."
Hide
Permalink
Alexandre Santos added a comment -

I've changed the line 107 to this:

String hostWithCredentials = username + ":" + password + "@" + wsdlUrl.getHost() + ":" + wsdlUrl.getPort();

and it worked. Why have you used an if condition?

Show
Alexandre Santos added a comment - I've changed the line 107 to this: String hostWithCredentials = username + ":" + password + "@" + wsdlUrl.getHost() + ":" + wsdlUrl.getPort(); and it worked. Why have you used an if condition?
Hide
Permalink
Rob Whelan added a comment -

The if condition is because the port in a java.net.URI may be left undefined – in that case wsdlUrl.getPort() will return -1.

It's possible that in current Mirth code the port is always defined; I took the safe approach and didn't assume it.

If you want to drop the if condition, be sure to test using a WSDL URL with no port specified.

Show
Rob Whelan added a comment - The if condition is because the port in a java.net.URI may be left undefined – in that case wsdlUrl.getPort() will return -1. It's possible that in current Mirth code the port is always defined; I took the safe approach and didn't assume it. If you want to drop the if condition, be sure to test using a WSDL URL with no port specified.
Hide
Permalink
Nick Rupley added a comment -

Confirmed that wsdlUrl.getPort() returns -1 if it's not specified in the URL property (and when it's then converted into a URI in the servlet).

Show
Nick Rupley added a comment - Confirmed that wsdlUrl.getPort() returns -1 if it's not specified in the URL property (and when it's then converted into a URI in the servlet).
Hide
Permalink
Nick Rupley added a comment -

Fixed in revisions 6233 (2.x) and 6234 (3.0).

Show
Nick Rupley added a comment - Fixed in revisions 6233 (2.x) and 6234 (3.0).

People

  • Assignee:
    Nick Rupley
    Reporter:
    Rob Whelan
Vote (3)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: