Mirth Connect
  1. Mirth Connect
  2. MIRTH-3131

Replace the File Reader directory/filter pattern/username/password once per poll, not once on deploy

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2.0
    • Component/s: Server
    • Labels:
      None

      Description

      Right now if you use global map variables in the directory / filename filter pattern, you might expect the channel to update the fields on subsequent polling periods. However right now they're just replaced once on channel deploy and kept static until the next deploy.

        Activity

        Hide
        Sticky Bandit added a comment -

        I vote for this option to be in the next release and provide an option to the user to either choose ON DEPLOY or ON POLLING for the directory and filename filter pattern.

        Show
        Sticky Bandit added a comment - I vote for this option to be in the next release and provide an option to the user to either choose ON DEPLOY or ON POLLING for the directory and filename filter pattern.
        Hide
        John Henry Downing added a comment -

        Got a customer looking for this functionality as well. I see merit to having this be optional- on deploy / on polling

        Show
        John Henry Downing added a comment - Got a customer looking for this functionality as well. I see merit to having this be optional- on deploy / on polling
        Hide
        Jaysen Patton added a comment -

        I can definitely see there being cases when the user would want to opt out of template replacement per polling vs. on deploy. I initially thought we should include this as an option under the polling settings, but since it only applies to this connector, maybe it makes sense to add a separate subdivision within the panel. Any thoughts on where these settings should be housed?

        Show
        Jaysen Patton added a comment - I can definitely see there being cases when the user would want to opt out of template replacement per polling vs. on deploy. I initially thought we should include this as an option under the polling settings, but since it only applies to this connector, maybe it makes sense to add a separate subdivision within the panel. Any thoughts on where these settings should be housed?
        Hide
        Jaysen Patton added a comment -

        It makes sense for this connector to always replace on poll. Can anyone think of a use case where they would use it on deploy?

        Show
        Jaysen Patton added a comment - It makes sense for this connector to always replace on poll. Can anyone think of a use case where they would use it on deploy?
        Hide
        Jaysen Patton added a comment -

        The File Reader will now replace the directory, filter pattern, username and passwords on each poll.

        The original replacement code was moved to the onStart task and global variables have been created to store the additional replacement fields on poll. The method signature, getConnectionPool, had the connectorProperties argument removed in lieu of passing in the username and password directly since these are the only pieces of information used from the properties. All code that referenced this method were updated to conform to the changes.

        Show
        Jaysen Patton added a comment - The File Reader will now replace the directory, filter pattern, username and passwords on each poll. The original replacement code was moved to the onStart task and global variables have been created to store the additional replacement fields on poll. The method signature, getConnectionPool, had the connectorProperties argument removed in lieu of passing in the username and password directly since these are the only pieces of information used from the properties. All code that referenced this method were updated to conform to the changes.
        Hide
        Nick Rupley added a comment -

        Verified that replaceable File Reader fields are now replaced each time a poll is performed, rather than once when the channel is deployed.

        Show
        Nick Rupley added a comment - Verified that replaceable File Reader fields are now replaced each time a poll is performed, rather than once when the channel is deployed.

          People

          • Assignee:
            Jaysen Patton
            Reporter:
            Nick Rupley
          • Votes:
            6 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development